Fix clean up of old attributes when containers are not restarting #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a pod crashes while in the process of starting, the operator cleans up outdated attributes in the galera CR status. The operator wrongly assumes that it can probe a container's state as soon as it gets a pod object from the API server, which is not always true (e.g when the pod is in "Pending" state). Fix the attribute clean up by always checking the state of the pod's container before inspecting its container ID. Jira: OSPRH-9411
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, dciabrin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1dde489
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a pod crashes while in the process of starting, the operator cleans up outdated attributes in the galera CR status.
The operator wrongly assumes that it can probe a container's state as soon as it gets a pod object from the API server, which is not always true (e.g when the pod is in "Pending" state).
Fix the attribute clean up by always checking the state of the pod's container before inspecting its container ID.
Jira: OSPRH-9411